Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UploadFileItem.filetype should be defined as optional #1161

Open
PercipioDrew opened this issue Jan 30, 2023 · 0 comments · May be fixed by #1162
Open

UploadFileItem.filetype should be defined as optional #1161

PercipioDrew opened this issue Jan 30, 2023 · 0 comments · May be fixed by #1162

Comments

@PercipioDrew
Copy link

When using the RNFS.uploadFiles method, there is a type definition named UploadFileItem with field filetype where the docs say...

if not defined it will get mimetype from filepath extension

However, the type defines that field as required so it must be defined. Can we please switch it to be optional? Otherwise, we have to explicitly specify the filetype.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change typedef for UploadFileItem so filetype field is optional PercipioDrew/react-native-fs
1 participant
@PercipioDrew