Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with ESP32 #30

Open
SciLor opened this issue Jan 7, 2018 · 9 comments
Open

Incompatible with ESP32 #30

SciLor opened this issue Jan 7, 2018 · 9 comments

Comments

@SciLor
Copy link

SciLor commented Jan 7, 2018

The library seems not to work on the ESP32.
Boards: https://github.com/espressif/arduino-esp32

I always get "error: 'Thread' has not been declared"
Using the ESP8266 boards it works fine

@SciLor
Copy link
Author

SciLor commented Apr 29, 2018

@ivanseidel
Copy link
Owner

Can you please check #include <Thread.h> is the first included file from the library, and that it is indeed included?

Also, please post the code here so we can understand better.

(Luckily, yesterday I was using a ESP32... but did not use it with ArduinoThread)

@SciLor
Copy link
Author

SciLor commented Apr 30, 2018

The code is here:
https://github.com/SciLor/ESP8266_Hyperion_LED-Controller/blob/develop/HyperionRGB/EnhancedThread.h

You can reproduce the problem easily:
Create a new Arduino Sketch.
Create an EnhancedThread.cpp with:

#include "EnhancedThread.h"
void EnhancedThread::run() {
  Thread::run();
}

and EnhancedThread.h

#include <Thread.h>
class EnhancedThread : public Thread {
  public:
    void
      run(void);
};

Select the Wemos LOLIN32 or ESP32 Devboard as device.
Compile - error

Known workarounds: Copy the ArduinoThread lib into the projects folder or combine the h+cpp file into one file.

Use Arduino / ESP8266 and it works fine.

@ivanseidel
Copy link
Owner

ivanseidel commented Apr 30, 2018 via email

@SciLor
Copy link
Author

SciLor commented Apr 30, 2018

I have added #include <Thread.h> in the other 2 files without success. The error stays the same.

@phoax
Copy link

phoax commented Jul 26, 2018

I'm testing this lib with a standard ESP32 and Visual Code. It works fine.

@SciLor
Copy link
Author

SciLor commented Jul 26, 2018

I am using the Arduino Software

@phoax
Copy link

phoax commented Jul 31, 2018

@patrickelectric
Copy link

I'm using this library with ESP32 without any problem. For nodemcu and wimos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants