Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire DownloadBuilder-hijack-way of building-demos #25

Open
rxaviers opened this issue Nov 9, 2012 · 5 comments
Open

Retire DownloadBuilder-hijack-way of building-demos #25

rxaviers opened this issue Nov 9, 2012 · 5 comments
Assignees

Comments

@rxaviers
Copy link
Member

rxaviers commented Nov 9, 2012

To save bytes and time, currently we're hijacking the jquery-ui checkout from download.jqueryui.com to copy demo files when building the demo.

Soon, Download Builder will handle multiple versions and the chance the get garbage (different checkout than expected) from its tmp dir is higher.

We may need to handle it by our own or find a consistent alternative.

@scottgonzalez
Copy link
Member

This just bit us again. See #32.

@jzaefferer
Copy link
Member

For the build-demos task we should just clone jQuery UI again instead of hijacking DB.

Since DB also has a bunch of git-related tasks, maybe we can build a little helper with we can include as a module in both DB and this repo's grunt file.

@jzaefferer
Copy link
Member

Scott actually built a tool around git, though focusing on "a bunch of functions that make writing custom git commands or other git-based scripts much easier": https://github.com/scottgonzalez/node-git-tools

Could have something like Repo.fetch() which would handle cloning or fetching based on whether the repo exists.

@jzaefferer
Copy link
Member

We can do a flat clone, since we don't need the full history to generate the demos. Just need the revision we're putting on the site. Use the --depth <depth> option to load only the specified number of revisions.

@jzaefferer
Copy link
Member

This still sucks.

@Krinkle Krinkle self-assigned this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants