Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GP/JSD #42

Closed
MartinKolarik opened this issue Apr 16, 2024 · 3 comments · Fixed by #43
Closed

Split GP/JSD #42

MartinKolarik opened this issue Apr 16, 2024 · 3 comments · Fixed by #43
Assignees

Comments

@MartinKolarik
Copy link
Member

After https://github.com/jsdelivr/meta/issues/50, we'll need to split this into two repos.

@alexey-yarmosh
Copy link
Member

sponsors collection is required by both jsd and gp.

jsd:

  • user_type: member | sponsor | special field

gp:

  • assign credits for recurring sponsorship (last assign date should be tracked)
  • user_type: member | sponsor | special field (is it required by gp?)

user_type field is set by:

  • github sponsorship webhook handler
  • cron sync of sponsors with github every day
  • user sign-up handler (searchs users in sponsors table)

My suggestion is to keep sponsors on gp dashboard as is. And jsd dashboard will not store sponsors explicitly, but only sync user_types of the users directly with github, which shouldn't be a lot in terms of requests (once per day + on every sign-up). That assumes that jsd dashboard don't need data like amount of donation etc.

Alternatively jsd dashboard may make sync calls to gp dashboard or vice-versa. Also jsd FE may make calls to gp dashboard BE to get user_type value. But that has its own drawbacks and looks messy.

@MartinKolarik
Copy link
Member Author

Eventually, we'll likely split even the GitHub organizations, and that means splitting sponsors (actually a good question @jimaek, shouldn't we do this sooner rather than later?). For now, keep everything GP needs there, and for JSD, either only keep the type or just ignore it (we won't be deploying the JSD dashboard until GP is done).

@jimaek
Copy link
Member

jimaek commented Apr 18, 2024

JSD has no sponsors related functionality at all. And its not needed either. So just move everything needed to GP and dont bother with it on JSD side.

Splitting orgs sounds like a bit too much at the moment, the site already requires lots of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants