Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module negotiator #29

Open
gjethwani opened this issue Mar 19, 2024 · 3 comments
Open

Cannot find module negotiator #29

gjethwani opened this issue Mar 19, 2024 · 3 comments

Comments

@gjethwani
Copy link

Hi!

Reporting a bug. When I import express, it imports accepts which imports negotiator. However, it seems that version 1.3.8 of accepts cannot find the negotiator dependency. It has to be explicitly installed in the project. Some more details:
Node version: 20.10.0
Express version: 4.17.0
Reverting to accepts 1.3.7 fixes the issue.

@jonchurch
Copy link
Member

I can't repro this, purge your node_modules and reinstall to see if it persists. If you can create a repro then we can look at it but I don't think there should be any breakage here

@gjethwani
Copy link
Author

I am able to repro it successfully after multiple attempts deleting node_modules and yarn.lock. I unfortunately am limited in how much code I can share due to this being corporate code, but I'm happy to provide any details you need to repro the issue

@jonchurch
Copy link
Member

jonchurch commented Mar 19, 2024

What version of yarn? Does it repro with npm install?

Can you do an npm ls or yarn list to dump your dep tree and share it?

Im still leaning that this is a dep resolution issue on your machine. We pin deps under the express family of orgs so the dep tree really doesnt shift around. But how it is reconciled in your project on your machine can always be a pleasant surprise!

But its just guessing unless you can create a minimal repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants