We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What would you like to be added:
type ObjectStorage interface { Get(ctx context, key string, off, limit int64, getters ...AttrGetter) (io.ReadCloser, error) } // i.e. pass the context instead of context.Background() func (s *s3client) Get(ctx context, key string, off, limit int64, getters ...AttrGetter) (io.ReadCloser, error) { .... resp, err := s.s3.GetObjectWithContext(ctx, params, request.WithGetResponseHeader(s3RequestIDKey, &reqID)) }
Why is this needed:
we start goroutines to handle requests for object storage, need to cancel requests in case of exceptions, such as when a timeout happened.
https://github.com/juicedata/juicefs/pull/4582/files/5036cdcfe8d3ec2aa1a3eb166432d1759c6acaa7#r1549113348
The text was updated successfully, but these errors were encountered:
jiefenghuang
No branches or pull requests
What would you like to be added:
Why is this needed:
we start goroutines to handle requests for object storage, need to cancel requests in case of exceptions, such as when a timeout happened.
https://github.com/juicedata/juicefs/pull/4582/files/5036cdcfe8d3ec2aa1a3eb166432d1759c6acaa7#r1549113348
The text was updated successfully, but these errors were encountered: