Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize issues with urth-viz-explorer #59

Open
peller opened this issue Aug 18, 2016 · 1 comment
Open

Resize issues with urth-viz-explorer #59

peller opened this issue Aug 18, 2016 · 1 comment

Comments

@peller
Copy link
Collaborator

peller commented Aug 18, 2016

Follow-up to #2, which enables urth-viz-vega to resize based on its container

  1. urth-viz-explorer expands to fit the width of the notebook, but in dashboard mode, where the height of the cell changes, the explorer does not expand. This is because the notebook's output divs have no explicit sizing. We could look up the DOM to the div.cell and set the size to match that. All other widgets must have the same problem?
  2. Also, the collapsible cards may overlap with the cell in dashboard mode. Should overflow be hidden or scroll? Potentially needs to be set both for uses of urth-viz-explorer and also urth-viz-query independently.
  3. (actually an urth-viz-vega issue) The resize behavior of vega-lite currently assumes width and height are the size of the plot area and does not account for axes or labels. We've worked around this with a padding fudge factor of 150px. See Support top-level padding / autosize property vega/vega-lite#1496, Document about setting width and height via Vega's View Component API vega/vega-lite#1497
@peller peller self-assigned this Aug 18, 2016
peller added a commit to peller/declarativewidgets_explorer that referenced this issue Aug 18, 2016
@dalogsdon
Copy link
Contributor

All other widgets must have the same problem?

Yes, I've seen the problem with other widgets such as the globe.

Should overflow be hidden or scroll?

Only if there is a use case where the explorer is expected to be used with the query in dashboard view. This also raises the question of whether the expand/JSON buttons should be displayed in dashboard view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants