Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check spelling, links of website HTML #56

Open
bollwyvl opened this issue Jun 15, 2020 · 1 comment · May be fixed by #58
Open

Check spelling, links of website HTML #56

bollwyvl opened this issue Jun 15, 2020 · 1 comment · May be fixed by #58

Comments

@bollwyvl
Copy link

Now that #53 is more formally publishing a website, additional measures would be a nice addition to achieve (and keep) high quality text, and reduce review time.

I don't know if these would be things that would need their own JEP, or are just nuts-and-bolts that fall out of (and would need documenting anwyay) in #29.

Notionally these would be run on every PR push.

spelling

tool: hunspell

There are a bunch of other ones, but hunspell, can be installed via most system package manager or conda. windows is less rosy.

I've found it best set up to test against generated HTML, where the semantics are more clear than markdown.... though would be happy to hear if anyone has something better.

While somewhat odius, maintaining a single dictionary.txt (just a sorted list of words, or a cleverer, but less portable stem-aware confection) across a corpus is good for keeping jargon and names consistent, e.g. JupyterHub vs Jupyterhub.

This also interestingly adds some more punch to the "new terms" part of the template.

links

tool: https://github.com/jupyterlab/pytest-check-links

Used on other jupyter projects, though other options exist. We recently added some caching stuff to try to reduce the amount of rate limiting that was occurring for some public sites. The in-document anchor checking doesn't quite work for sphinx output, but a fix has been merged, and could probably be released.

@choldgraf
Copy link
Contributor

My 2 cents about scope: IMO these are all in-scope from #29 as implementations of the phrasing that there should be a public website where JEPs are displayed.

@bollwyvl bollwyvl linked a pull request Jun 19, 2020 that will close this issue
bollwyvl added a commit to bollwyvl/enhancement-proposals that referenced this issue Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants