Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.5.6: pep517 build fails #251

Open
kloczek opened this issue May 16, 2023 · 2 comments
Open

0.5.6: pep517 build fails #251

kloczek opened this issue May 16, 2023 · 2 comments

Comments

@kloczek
Copy link

kloczek commented May 16, 2023

Looks like something is wrong and pep517 based build fails with:

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting build dependencies for wheel...
running egg_info
creating nbclassic.egg-info
writing nbclassic.egg-info/PKG-INFO
writing dependency_links to nbclassic.egg-info/dependency_links.txt
writing entry points to nbclassic.egg-info/entry_points.txt
writing requirements to nbclassic.egg-info/requires.txt
writing top-level names to nbclassic.egg-info/top_level.txt
writing manifest file 'nbclassic.egg-info/SOURCES.txt'
reading manifest file 'nbclassic.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
/usr/lib/python3.8/site-packages/setuptools/command/sdist.py:119: SetuptoolsDeprecationWarning: `build_py` command does not inherit from setuptools' `build_py`.
!!

        ********************************************************************************
        Custom 'build_py' does not implement 'get_data_files_without_manifest'.
        Please extend command classes from setuptools instead of distutils.

        See https://peps.python.org/pep-0632/ for details.
        ********************************************************************************

!!
  self._add_data_files(self._safe_data_files(build_py))
warning: no files found matching 'Dockerfile'
warning: no directories found matching 'notebook/tests'
warning: no directories found matching 'notebook/i18n'
warning: no previously-included files found matching 'docs/#*'
warning: no directories found matching 'examples'
no previously-included directories found matching 'docs/build'
no previously-included directories found matching 'docs/gh-pages'
no previously-included directories found matching 'docs/dist'
no previously-included directories found matching 'git-hooks'
no previously-included directories found matching 'docs-translations'
warning: no previously-included files matching '*~' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '*.pyo' found anywhere in distribution
warning: no previously-included files matching '.git' found anywhere in distribution
warning: no previously-included files matching '.ipynb_checkpoints' found anywhere in distribution
adding license file 'LICENSE'
writing manifest file 'nbclassic.egg-info/SOURCES.txt'
* Building wheel...
running bdist_wheel
running jsversion
running js
running jsdeps
installing build dependencies with npm
> npm install
npm WARN deprecated crypto@1.0.1: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.
npm WARN deprecated cryptiles@2.0.5: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated boom@2.10.1: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated sntp@1.0.9: This module moved to @hapi/sntp. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.
npm WARN deprecated nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated hoek@2.16.3: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated request@2.81.0: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@4.2.1: this library is no longer supported
npm WARN deprecated hawk@3.1.3: This module moved to @hapi/hawk. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.
npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
npm WARN deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

added 479 packages, and audited 480 packages in 39s

50 packages are looking for funding
  run `npm fund` for details

12 vulnerabilities (6 moderate, 1 high, 5 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
> bower install --allow-root --config.interactive=false
bower xterm.js-css#*            cached https://unpkg.com/xterm@~3.1.0/dist/xterm.css#e-tag:e0b-Roy3Y
bower xterm.js-css#*          validate e-tag:e0b-Roy3Y against https://unpkg.com/xterm@~3.1.0/dist/xterm.css#*
bower xterm.js#*                cached https://unpkg.com/xterm@~3.1.0/dist/xterm.js#e-tag:3fd9c-C6P
bower xterm.js#*              validate e-tag:3fd9c-C6P against https://unpkg.com/xterm@~3.1.0/dist/xterm.js#*
bower xterm.js-fit#*            cached https://unpkg.com/xterm@~3.1.0/dist/addons/fit/fit.js#e-tag:b15-J97io
bower xterm.js-fit#*          validate e-tag:b15-J97io against https://unpkg.com/xterm@~3.1.0/dist/addons/fit/fit.js#*
bower create-react-class#*      cached https://cdn.jsdelivr.net/npm/create-react-class@15.6.3/create-react-class.min.js#e-tag:W/"1d26-/4
bower create-react-class#*    validate e-tag:W/"1d26-/4 against https://cdn.jsdelivr.net/npm/create-react-class@15.6.3/create-react-class.min.js#*
bower backbone#~1.2             ENOGIT git is not installed or not in the PATH
rebuilding js and css failed. The following required files are missing: ['nbclassic/static/components', 'nbclassic/static/notebook/js/main.min.js', 'nbclassic/static/tree/js/main.min.js', 'nbclassic/static/edit/js/main.min.js', 'nbclassic/static/terminal/js/main.min.js', 'nbclassic/static/auth/js/main.min.js', 'nbclassic/static/style/ipython.min.css', 'nbclassic/static/style/style.min.css']
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
  File "/usr/lib/python3.8/site-packages/pyproject_hooks/_in_process/_in_process.py", line 335, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "/usr/lib/python3.8/site-packages/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
    return _build_backend().build_wheel(wheel_directory, config_settings,
  File "/usr/lib/python3.8/site-packages/jupyter_packaging/build_api.py", line 23, in build_wheel
    val = orig_build_wheel(
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 416, in build_wheel
    return self._build_with_temp_dir(['bdist_wheel'], '.whl',
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 401, in _build_with_temp_dir
    self.run_setup()
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 338, in run_setup
    exec(code, locals())
  File "<string>", line 111, in <module>
  File "<string>", line 108, in main
  File "/usr/lib/python3.8/site-packages/setuptools/__init__.py", line 107, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 185, in setup
    return run_commands(dist)
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
    dist.run_commands()
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python3.8/site-packages/setuptools/dist.py", line 1244, in run_command
    super().run_command(command)
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/home/tkloczko/rpmbuild/BUILD/nbclassic-0.5.6/setupbase.py", line 642, in run
    raise e
  File "/home/tkloczko/rpmbuild/BUILD/nbclassic-0.5.6/setupbase.py", line 631, in run
    self.distribution.run_command('js')
  File "/usr/lib/python3.8/site-packages/setuptools/dist.py", line 1244, in run_command
    super().run_command(command)
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/home/tkloczko/rpmbuild/BUILD/nbclassic-0.5.6/setupbase.py", line 573, in run
    self.run_command('jsdeps')
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
    self.distribution.run_command(command)
  File "/usr/lib/python3.8/site-packages/setuptools/dist.py", line 1244, in run_command
    super().run_command(command)
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/home/tkloczko/rpmbuild/BUILD/nbclassic-0.5.6/setupbase.py", line 415, in run
    run(
  File "/home/tkloczko/rpmbuild/BUILD/nbclassic-0.5.6/setupbase.py", line 335, in run
    return check_call(cmd, *args, **kwargs)
  File "/usr/lib64/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['bower', 'install', '--allow-root', '--config.interactive=false']' returned non-zero exit status 1.

ERROR Backend subprocess exited when trying to invoke build_wheel
@echarles
Copy link
Member

We had similar report in #248 although the root cause in that case was a missing npm tool. I see in your log that npm is there.

I don't think we support python build for now. What would be the need for that?

@jtpio jtpio mentioned this issue May 17, 2023
Closed
@kloczek
Copy link
Author

kloczek commented Jul 1, 2023

I don't think we support python build for now. What would be the need for that?

You don't need to support build. All what you need is support PEP517 build procedure.
https://peps.python.org/pep-0517/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@echarles @kloczek