Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown entered by one user does not render for other users in the same session #311

Open
ibdafna opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ibdafna
Copy link
Member

ibdafna commented May 9, 2024

In a collaborative session, when user A inserts a new markdown cell, types some content in it and "executes" it so it renders, it only renders for user A, but not for all other users in the session. If user A inserts a code cell first, types in it, and then converts it to markdown cell and executes it - the markdown gets rendered for everyone in the session.

(demo towards the end of the animated gif)

rtc-testing-session

@ibdafna ibdafna added the bug Something isn't working label May 9, 2024
@davidbrochart
Copy link
Collaborator

The information about whether the Markdown cell is rendered or not is not part of the notebook format, nor the notebook shared model, it's purely a frontend thing that allows to edit a Markdown cell.
But we could maybe include that information in the notebook shared model. There are discussions about including the cell execution state in jupyter-server/jupyter_ydoc#197, which currently only concerns code cells. Maybe this could be more general and apply to Markdown cells too? For instance if we rename the possible values to rendered/rendering instead of idle/busy.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants