-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use multiple characters with international keyboards on MacOS in 4.1.0 #15744
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Thank you for the extra details! These shortcuts were introduced in #14799. We can add overrides for mac by adding |
I can add that this is also an issue with a German keyboard layout, since |
[
]
in editor with Italian keyboard on MacOS.
Noting the the many many option-digit keyboard shortcuts mean that things like option-3, which on a Mac UK keyboard is a # sign, don't work to give desired characters. |
I also note that there doesnlt seem to be a way to delete the current default bindings? |
Are the 20 different bindings all for one action intended? Or a bug? (If not a bug: why has this behaviour been chosen??). Ok, I see from the json settings and the PR discussion that the different bindings are for selecting different objects in the sidebar — but I’ll note that this isn’t reflected at all in the GUI settings editor. This seems like an obvious misfeature, along with an actual bug for the lack of ability to change the bindings in the editor... (See https://discourse.jupyter.org/t/weird-option-digit-keybindings) |
Can someone with a Mac confirm that setting: {
"shortcuts": [
{
"args": {
"side": "left",
"index": 0
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 1"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 1
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 2"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 2
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 3"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 3
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 4"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 4
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 5"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 5
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 6"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 6
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 7"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 7
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 8"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 8
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 9"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "left",
"index": 9
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt 0"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 0
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 1"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 1
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 2"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 2
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 3"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 3
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 4"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 4
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 5"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 5
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 6"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 6
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 7"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 7
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 8"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 8
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 9"
],
"macKeys": [],
"selector": "body"
},
{
"args": {
"side": "right",
"index": 9
},
"command": "application:toggle-side-tabbar",
"keys": [
"Alt Shift 0"
],
"macKeys": [],
"selector": "body"
},
]
} Disables the shortcuts on Mac? |
No, the shortcuts are still active, as opposed to the '"disabled": true' workaround, which helped. |
@krassowski Unfortunately not! The version with |
Thank you! I believe #15761 should help, can you confirm by testing it on Binder (click on this link: https://mybinder.org/v2/gh/krassowski/jupyterlab/disable-alt-key-on-mac?urlpath=lab |
MacOption + number and Shift-MacOption + number work as expected on Binder. |
It does seem to work on binder! But I tried to add a version with |
I can confirm, this workaround works for German keyboard layout too. |
For Italian keyboards try to override "Keyboard shortcuts" > "System Default" adding in "User Preferences": |
Hi, I found this to be a recession on my German keyboard too. Downgrading to |
It seems like the issue only appears when using jupyter lab/notebook with Safari (Version 17.3.1 ) I called the same jupyter server with Chrome (Version 122.0.6261.94 ) without any issues. |
Just for visibility the workaround for Mac users with international keyboards on JupyterLab 4.1.5 is to paste the following: {
"shortcuts": [
{
"args": {},
"command": "inline-completer:next",
"keys": [
"Alt ]"
],
"selector": ".jp-mod-completer-enabled",
"disabled": true
},
{
"args": {},
"command": "inline-completer:previous",
"keys": [
"Alt ["
],
"selector": ".jp-mod-completer-enabled",
"disabled": true
},
{
"args": {},
"command": "inline-completer:invoke",
"keys": [
"Alt \\"
],
"selector": ".jp-mod-completer-enabled",
"disabled": true
}
]
} In: I would greatly appreciate if someone could review the fix in #15927 (and the underlying jupyterlab/lumino#689). |
I can confirm, that the issue only seems to appear in Safari (Version 17.3.1 ). When opening the same notebook in Jupyter Lab on Brave Browser (version 1.62.125) I can enter |
This comment was marked as spam.
This comment was marked as spam.
Hello, I'm experiencing the same issue with |
Yes, it has been released last week in JupyterLab 4.2.0 - you need to upgrade to 4.2.x. |
@krassowski I am running JupyterLab 4.2.1 on https://demo.jupyter.b-data.ch (login with GitHub account). Terminal
|
@benz0li to clarify do you experience the problem with Option+G/Option+N only in the black terminal tab, or also in the notebook or Jupyter console? |
If this is in terminal only it could be related to xtermjs/xterm.js#2151 |
Only in the JupyterLab Terminal. Unfortunately, I do not have time to investigate further.
Unlikely. There is also |
@krassowski JupyterLab Python docker stack: Building the latest.Dockerfile with command docker build \
--build-arg PYTHON_VERSION=3.12.3 \
--build-arg JUPYTERLAB_VERSION=4.1.8 \
-t jupyterlab/python/base \
-f latest.Dockerfile .
it works in the Terminal but not in a Notebook or the Console. |
@krassowski I revised the statement of my last comment. Situation regarding e.g.
|
@benz0li thank you for further information! Would you be able to narrow this down by bisection to a 4.2 pre-release which started manifesting the problem? It may be pretty quick to test by using the bineder links in https://gist.github.com/krassowski/68adb59038d7334d698bea811ad4b039 |
Situation regarding e.g.
|
Ping @krassowski |
Description
Unable to use
[
]
in editor with Italian keyboard on macOS.Reproduce
The Italian keyboard does not have
[
]
keys, which are accessed via the option⌥
key. Apparently the new keyboard shortcuts⌥[
and⌥]
mask the ability to properly input these characters.a = [1]
[
]
do not appear.Please note that typing
[
at the start of a line results in the expected behaviour. Terminals work as expected.This bug surfaced after the installation of v. 4.1.0: v. 4.0.12 works as expected.
Context
Troubleshoot Output
Command Line Output
Nothing sensible here, apparently.
Browser Output
The text was updated successfully, but these errors were encountered: