-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send_file HTTP::Server::ClientError #591
Comments
I have the same issue. How to reproduce (don't know if it works on your environment):
There are some reports on this link crystal-lang/crystal#9065 |
may be file's path incorrect should be -> |
The See crystal-lang/crystal#9034 (comment) and crystal-lang/crystal#9115 (comment). |
I think this issue can safely be closed. |
It's an issue for high traffic applications, you are flooded by these logs, and you can't read the other useful lines of log. In invidious, we had to override the class in order to not get these exceptions: https://github.com/iv-org/invidious/blob/master/src/invidious/helpers/crystal_class_overrides.cr#L51 Otherwise, on a high traffic application we would get these errors every second: iv-org/invidious#1416 For me, it is still worth it to keep this issue open until we find a configurable parameter to mute these errors. Kemal is the only library where I have seen these error logs, I have never seen such logs in other libraries in other programming language. |
Hey @unixfox thanks a lot for the feedback, I'll reopen the issue. @straight-shoota do you have any idea if we can do anything about this in std-lib or kemal itself? |
Description
Throws various errors related to HTTP::Server and IO:Error however the content loads and works.
Steps to Reproduce
Expected behavior: No errors thrown, as the code is very basic and taken directly from the docs.
Actual behavior:
Reproduces how often: Everytime
Versions
OS: Mac OS Catalina
The text was updated successfully, but these errors were encountered: