Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Last release didn't include the change(s)? #196

Open
dobesv opened this issue Oct 7, 2020 · 0 comments
Open

Last release didn't include the change(s)? #196

dobesv opened this issue Oct 7, 2020 · 0 comments

Comments

@dobesv
Copy link
Contributor

dobesv commented Oct 7, 2020

Hi,

It seems like the typescript changes that were supposed to go into 6.3.5 are not there when I install from npm:

$ grep version node_modules/snappy/package.json 
  "version": "6.3.5"
$ cat node_modules/snappy/snappy.d.ts 
export function compress(input: string | Buffer, callback: (err: Error, buffer?: Buffer) => void): void;
export function compressSync(input: string | Buffer): Buffer;
export var isValidCompressed: (buffer: Buffer, callback: (err: Error | null, isValid?: boolean) => void) => void;
export var isValidCompressedSync: (buffer: Buffer) => boolean;
export function uncompress(compressed: Buffer, opts: any, callback: (err: Error, uncompressed?: string | Buffer) => void): void;
export function uncompressSync(compressed: Buffer, opts: any): string | Buffer;

Expected the current snappy.d.ts:

export function compress(input: string | Buffer, callback: (err: Error, buffer?: Buffer) => void): void;
export function compressSync(input: string | Buffer): Buffer;

export var isValidCompressed: (buffer: Buffer, callback: (err: Error | null, isValid?: boolean) => void) => void;
export var isValidCompressedSync: (buffer: Buffer) => boolean;

export function uncompress(compressed: Buffer, callback: (err: Error, uncompressed?: Buffer) => void): void;
export function uncompress(compressed: Buffer, opts: {asBuffer: false}, callback: (err: Error, uncompressed?: string) => void): void;
export function uncompress(compressed: Buffer, opts: {asBuffer: true}, callback: (err: Error, uncompressed?: Buffer) => void): void;

export function uncompressSync(compressed: Buffer): Buffer;
export function uncompressSync(compressed: Buffer, opts: {asBuffer: false} ): string;
export function uncompressSync(compressed: Buffer, opts: {asBuffer: true} ): Buffer;
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant