Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the capitalization #4

Open
danielo515 opened this issue Sep 30, 2016 · 3 comments
Open

Respect the capitalization #4

danielo515 opened this issue Sep 30, 2016 · 3 comments

Comments

@danielo515
Copy link

danielo515 commented Sep 30, 2016

Capitalization is usually important for header objects.
Request.js for example does not recognices authorization but it works with Authorization
Currently the output is always lowercase

Regards

@kesla
Copy link
Owner

kesla commented Oct 3, 2016

Idk if it's "usually important" - this module has been around for a while without it being requested before.

I don't need capitalization and if we're going to respect capitalization I think it should be configurable, considering that the spec says headers should be case-insensetive. So if you're interested in contribution, feel free to open a pull request!

@danielo515
Copy link
Author

Hello @kesla

I'm basing my guess on how requestjs which is some kind of nodejs standard behaves.
I'll agree that it should be configurable

@DmitryMyadzelets
Copy link

The RFC at section 4.2 says "Field names are case-insensitive".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants