Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop google translate dependency #2

Open
kfatehi opened this issue Aug 8, 2021 · 2 comments
Open

Drop google translate dependency #2

kfatehi opened this issue Aug 8, 2021 · 2 comments

Comments

@kfatehi
Copy link
Owner

kfatehi commented Aug 8, 2021

Promising library here https://github.com/argosopentech/argos-translate

Persian language is missing, and is voted on here argosopentech/argos-translate#91 (comment)

When you look at this project, you can see it is based on an open parallel database, and so I think it may be within reason that an individual could go and add Persian himself using that dataset. Is this true?

@nimkamp
Copy link
Collaborator

nimkamp commented Aug 10, 2021

Why are we dropping google translate? Google translate supports Persian and Vosk can be used to translate Persian audio to Persian text. Google Translate will then take the Persian text and convert to English text. English text to English Audio.

@kfatehi
Copy link
Owner Author

kfatehi commented Aug 11, 2021

@nimkamp i tried to explain my reasoning here https://github.com/kfatehi/pi-phone-dock#connectivity-requirements

basically 2 reasons:

  1. latency for round trip time to a third party service
  2. you might not always have internet access yet still want to use the tool.

also there's a baked in assumption that google will allow us to keep using it forever, so i consider these services as temporary anyway, it's just a matter of time before the put up blockers (like beefing up their security so that the method used by the library to access it will no longer work / enforcing usage with a captcha on the website, things like that.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants