Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support indeterminate state (tristate) #54

Open
lolmaus opened this issue Sep 19, 2016 · 6 comments
Open

Support indeterminate state (tristate) #54

lolmaus opened this issue Sep 19, 2016 · 6 comments

Comments

@lolmaus
Copy link
Collaborator

lolmaus commented Sep 19, 2016

Currently Ember has no checkbox addon with support for three states. ember-cli-toggle could be the first!

@knownasilya
Copy link
Owner

How would you see that working visually in a toggle?

@lolmaus
Copy link
Collaborator Author

lolmaus commented Sep 19, 2016

Naturally, the knob stays in the middle. Could also change its color.

@knownasilya
Copy link
Owner

Actually, currently this is almost supported. Basically if the value is not a valid value, then it will set a class invalid-state on the component, which could be used to style the element as indeterminate.

@knownasilya
Copy link
Owner

We can revisit this I think if the value is undefined we set to indeterminate state. This will take some work to update all of the styles to support this. I don't currently have the time to implement this, so if anyone wants to pick it up, I'd be happy to work with you to get it to the finish line.

@lolmaus
Copy link
Collaborator Author

lolmaus commented Sep 12, 2017

We can revisit this I think if the value is undefined we set to indeterminate state.

I'm afraid this will be a severely breaking change. We can avoid this with an extra param like tristate=true.

@knownasilya
Copy link
Owner

It could always be a v6 enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants