Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of pages to display #1

Open
knownasilya opened this issue Mar 26, 2014 · 7 comments
Open

Limit number of pages to display #1

knownasilya opened this issue Mar 26, 2014 · 7 comments

Comments

@knownasilya
Copy link
Owner

Sometimes it's very impractical to display 20+ page numbers, especially on mobile devices.

The api should allow for a way to specify the maximum number of pages to display, like a display attribute.

[ < | 1, 2, 3, ..., 10, 20, 30, 40, ..., 50, 51, 52 | > ]

Maybe some other format..

@k3nsei
Copy link
Contributor

k3nsei commented Sep 14, 2014

knownasilya: Here is my fork which include that functionality.
https://github.com/k3nsei/ember-twbs-pagination

@knownasilya
Copy link
Owner Author

@k3nsei PR is welcome 😄

@k3nsei
Copy link
Contributor

k3nsei commented Sep 15, 2014

@knownasilya
What you mean saying PR?

@knownasilya
Copy link
Owner Author

A pull request, it's when you fork my project (your version isn't a real
fork) and make the changes on a new branch and then push them up and create
a pull request so that I can merge it into this project. Very handy feature.
On Sep 15, 2014 7:55 AM, "k3nsei" notifications@github.com wrote:

@knownasilya https://github.com/knownasilya
What you mean saying PR?


Reply to this email directly or view it on GitHub
#1 (comment)
.

@k3nsei
Copy link
Contributor

k3nsei commented Sep 15, 2014

@knownasilya I'm new to git and github. Sorry for that. You can adopt this changes very simply to your project.

@knownasilya
Copy link
Owner Author

Sounds good, although I recommend you go and learn this process as soon as
you can :)
On Sep 15, 2014 8:05 AM, "k3nsei" notifications@github.com wrote:

@knownasilya https://github.com/knownasilya I'm new to git and github.
Sorry for that. You can adopt this changes very simply to your project.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@knownasilya
Copy link
Owner Author

In as of 36cbc8c, but still needs some polishing to improve API and display. Mainly sometimes it adds or removes items, changing the size. Also if there are x items, the '...' shouldn't display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants