-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arb.list fails within edge cases in case of null values #3981
Comments
This shall fix the issue as described in #3981. Instead of just assuming that a null value means "there is no edge case", this change adds explicitly checking that, effectively fixing the problem.
Fixed in 5.9.0. |
Change being reverted due to performance impact. In 6.0 we will change the |
That's a pity, as this will cause some tests to break again :( |
Ah - found the reported issue; I like addressing the nullability issue. However, how about going back to previous behavior, but with a workaround for the failing test issue? What happened was: if the result was null, it would be treated as "there is no edge case", leading to an index exception. (Edit: obviously this shall be a temporary workaround until 6.0, assuming the latter will still take a while.) |
Could you draft a PR to show what you mean? I'll create a separate issue for addressing nullability |
Test case:
Arb.list(Arb.constant(null), 1..100).edgecases().forAll { }
Expected: Passes and generates lists of null with a variable length.
Actual:
java.util.NoSuchElementException: Collection is empty.
in collections.kt, Line 108.Note: This passes if the lower boundary is set to
0
.Currently, edge cases returning null will lead to the conclusion "there is no edge case for this arb" and subsequently fall back to use a random value. If this is null, too, then the particular edge case for the list is ignored. However, this is not only incorrect (either the edge case or the random value might actually be null), but causes no edge case to be left; therefore the random selection of edge cases fails with "Collection is empty."
I'll submit a PR to address this.
The text was updated successfully, but these errors were encountered: