Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker.h curLabel out of range #193

Open
p0xky-xyz opened this issue May 27, 2016 · 1 comment
Open

Tracker.h curLabel out of range #193

p0xky-xyz opened this issue May 27, 2016 · 1 comment

Comments

@p0xky-xyz
Copy link

p0xky-xyz commented May 27, 2016 •
edited

I think uint curLabel gets an out of range if my thread is running during a long time.
To avoid this, i create this fix. what do yo think?
unsigned int getNewLabel() { if (curLabel>=UINT_MAX) { curLabel = 0; } else { curLabel++; } return curLabel; }

thanks
@kylemcdonald
Copy link
Owner

This is related to #202

avilleret added a commit to avilleret/ofxCv that referenced this issue Feb 12, 2017
@avilleret
extend curLabel range to [0..std::limits<unsigned long long>::max()] …
609b605 
…and warp when reaching limits

fix #kylemcdonald#193
@avilleret avilleret mentioned this issue Feb 12, 2017
Merged
kylemcdonald added a commit that referenced this issue Mar 24, 2018
@kylemcdonald
Merge pull request #210 from avilleret/fix/#193
cb76ee5 
extend curLabel range to [0..std::limits<unsigned long long>::max()] …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylemcdonald @p0xky-xyz