Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register 'messagebird' channel #32

Open
WouterFlorijn opened this issue Mar 1, 2021 · 1 comment
Open

Register 'messagebird' channel #32

WouterFlorijn opened this issue Mar 1, 2021 · 1 comment

Comments

@WouterFlorijn
Copy link

Currently, use of this package is inconsistent. In most cases (for example in the via method), the channel needs to be MessagebirdChannel::class. However, when routing an anonymous notification, the channel needs to be 'messagebird':

Notification::route('messagebird', $phoneNumber)->notify(...);

I think Notification::resolved could be used in the MessagebirdServiceProvider to accomplish this. See for example the Nexmo implementation.

@zenire
Copy link

zenire commented Jan 3, 2022

@petericebear What is needed to resolve this issue? Looking if I can help somehow, but I see a PR has been made already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants