Various memory leaks

[wheybags]

@dwimsey Getting a bunch of memory leaks from valgrind in my project, made a minimal example which exhibits the same behaviour, by editing Samples/pyinvaders/src/main.cpp to: https://gist.github.com/wheybags/802237fb51fa63af22c5 (removes the whole game + just loads one rml document) + copying in the rml from samples/tutorial/template.
This gives the following errors in valgrind: https://gist.github.com/wheybags/ddfa929632fcf733059e and https://gist.github.com/wheybags/29e3af2995bff44a0892 with --show-leak-kinds=all
These leaks only seem to show up when python is enabled.
Just wanted to confirm that these aren't false positives. I can start going through the source trying to fix these leaks (ugh), if needs be.

[wheybags]

Or an I just not cleaning up properly?

[dwimsey]

I can’t give you a solid answer on that. I can think of a couple reasons while valgrind might get confused:

Python objects get attached to the RML objects and stick around until the RML objects have been deleted and a GC collection is done, I don’t know if python does a GC collection on exit or it just quits. I would expect it to do a collection so all resources can be closed properly rather than just terminated. In Lua, some objects stick around even after the RML has been destroyed because of references to them in the Lua code that hasn’t been GC’d yet, have no idea if the Python code has the same sort of relationship mapping issue.

I do remember at one point that the python library itself complained about memory leaks when exiting but my recollection of those leaks was that they were somewhat global objects that didn’t seem to be a big concern as they wouldn’t bloat over time, just globals that didn’t get cleaned up on exit properly. I could be remembering it entirely wrong.

I’m certain SOME of those leaks are actually leaks, if not all. Valgrind is generally right in my experience … not always, but pretty close.

On Jan 11, 2015, at 2:26 PM, Tom Mason notifications@github.com wrote:

@dwimsey https://github.com/dwimsey Getting a bunch of memory leaks from valgrind in my project, made a minimal example which exhibits the same behaviour, by editing Samples/pyinvaders/src/main.cpp to: https://gist.github.com/wheybags/802237fb51fa63af22c5 https://gist.github.com/wheybags/802237fb51fa63af22c5 (removes the whole game + just loads one rml document) + copying in the rml from samples/tutorial/template.
This gives the following errors in valgrind: https://gist.github.com/wheybags/ddfa929632fcf733059e https://gist.github.com/wheybags/ddfa929632fcf733059e and https://gist.github.com/wheybags/29e3af2995bff44a0892 https://gist.github.com/wheybags/29e3af2995bff44a0892 with --show-leak-kinds=all
These leaks only seem to show up when python is enabled.
Just wanted to confirm that these aren't false positives. I can start going through the source trying to fix these leaks (ugh), if needs be.

—
Reply to this email directly or view it on GitHub #238.

[wheybags]

There are a bunch of false positives generated by pythons internal memory allocator, but I'm suppressing those. I guess I'll have to look further into these leaks
/me sighs