Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libgit2 git_transport_certificate_check_cb #505

Open
phatblat opened this issue Aug 10, 2015 · 1 comment
Open

Add support for libgit2 git_transport_certificate_check_cb #505

phatblat opened this issue Aug 10, 2015 · 1 comment

Comments

@phatblat
Copy link
Member

It looks like the old way of providing libgit2 with certificate locations doesn't work without OpenSSL #499.

After a little bit of research, I think that
git_transport_certificate_check_cb (part of git_remote_callbacks) needs to be exposed somehow so that applications can provide custom server trust validation. This may be essential for sandboxed apps if the new SecureTransport support in libgit2 doesn't already tap into the root CA certs.

This callback was added in libgit2 0.22

Update: This callback appears to be unnecessary for normal certificate validation. It's only needed for providing a custom cert.

@jaanus
Copy link
Contributor

jaanus commented Aug 10, 2015

Everything works as expected for me with the latest code f2e17cd in a sandboxed OSX app on Yosemite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants