Clean up browser logs

[d-ivashchuk]

Mode

No response

Feature description

Potentially introduce the flag to mute the browser logs.

[tigerabrodi]

@d-ivashchuk maybe i could start with this?

forking the repo right now

do you've a discord i can add you in?

[d-ivashchuk]

This one seems to be perfect 👍🏼 @narutosstudent

[d-ivashchuk]

I am not yet sure how discord works, even using it for gaming for years now 😂😅 do I have a username there?

[d-ivashchuk]

@narutosstudent if you don't mind I will point your to the rights parts of codebase so you have easier time navigating! But tomorrow already, quite a day it was!

[tigerabrodi]

@d-ivashchuk sounds good, discord shouldn't be necessary tbh 😂

Github got enough ways to communicate, even emojis here lol 💀

I'm happy to also hack on features eventually, will go through the codebase this evening and make sure to study it a bit, will try to take notes of questions I've that you could respond to.

Thank you ❤️ .

[tigerabrodi]

@d-ivashchuk It might be a bit small, but check the top left chrome group of mine, lost-pixel 😎 🔥 got the fork and this github issue open, ready anytime 💪 😄

[d-ivashchuk]

If you will have time and gather some amount of questions already - we can even jump on quick call in the evening 😊

[judicaelandria]

If you will have time and gather some amount of questions already - we can even jump on quick call in the evening 😊

Hey can I join too? would love to know more about this project for future contribution :)

[d-ivashchuk]

@judicaelandria absolutely, I will work on the weekend to create some issues that would be good first issues and make it easier for people of various knowledge and backgrounds to contribute! Thanks for your interest 🥇

[d-ivashchuk]

@narutosstudent soo the scope of the issue is quite limited. Trying to be more verbose in debugging at some point we've added this chunk of code which is responsible for piping the browser logs to the general logs of lost-pixel. Those are seen on the runs in the CI and if you have some problems with your screenshots it makes it easier to debug.

Image for informational purposes - it does not have browser logs in this case!

the main problem with it is that sometimes it just pollutes the console in cases where we are not interested in the logs. Meaning we have couple of options to remedy this:

1. introduce {muteBrowserLogs: true} logs flag to lostpixel.config
2. introduce general logs flag {logs: 'VERBOSE' | 'INFO' } - INFO being the default and just having all the informational and error logs from lost-pixel run and VERBOSE covering the case for browser logs. the question here would be if we would not need to introduce other log levels in the future. this approach implies we'd at least try to make it right from first shot

I am very much happy to listen to your suggestions and explore good practices though @narutosstudent, I bet tools like Cypress or Playwright have it figured out already and maybe you could check those out first :D

@chriskalmar thoughts?

[judicaelandria]

@judicaelandria absolutely, I will work on the weekend to create some issues that would be good first issues and make it easier for people of various knowledge and backgrounds to contribute! Thanks for your interest 🥇

cool! here's my email for the invitation judicaelandria7@gmail.com

[tigerabrodi]

@d-ivashchuk Sorry for the late response, was busy 😄 ❤️

Let me read your reply.

Yes, I'm happy to jump on a call.

Feel free to invite me to a meeting that fits for you, Zoom or Google Meet ❤️

My email: tigerabrodi@gmail.com

Though we may not need a meeting yet, I'm happy to pair code and learn more about the codebase ❤️

@d-ivashchuk At work, we're using this package to make sure when a console error happens, that the test fails: https://www.npmjs.com/package/cypress-fail-on-console-error

the main problem with it is that sometimes it just pollutes the console in cases where we are not interested in the logs. Meaning we have couple of options to remedy this:

I see, so the goal here is for the logs in CI to be cleaned up, so it doesn't get too dirty, am I right?

[tigerabrodi]

@judicaelandria You can continue on this if you want, I've decided to step away from open-source as I'm busy with other things. 👍