Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange results of raster-contrast paint property #3967

Open
slaviczavik opened this issue Apr 10, 2024 · 3 comments
Open

Strange results of raster-contrast paint property #3967

slaviczavik opened this issue Apr 10, 2024 · 3 comments

Comments

@slaviczavik
Copy link

maplibre-gl-js version: 4.1.2

browser: Chrome 123.0.6312.105

Steps to Trigger Behavior

Easiest way to trigger the behavior is to run the example (link below) and switch style with buttons above map.

  1. Init MapLibre with an initial style.
  2. Update layer's paint raster-contrast property value.
  3. Watch difference between values 0.9 and 1.

Link to Demonstration

JS Bin with simplest example.

Expected Behavior

Rendered result of raster-contrast: 1 should be very similar to raster-contrast: 0.9.

Actual Behavior

The result of raster-contrast: 1 looks more similar to raster-contrast: -1.

Example of strange difference between 0.99 and 1.

unnamed

@sbachinin
Copy link
Collaborator

Can't reproduce it on my windows comp. Contrast 1 looks fine for me

@slaviczavik
Copy link
Author

I have just tested it on Windows in Chrome 123.0.6312.88 (64-bit) with same result – with contrast 1 it is greyish and way different than 0.9 –> same as on the picture.

@HarelM
Copy link
Member

HarelM commented Apr 10, 2024

This is what I get for 1 on my windows machine, very close to 0.9.
image
Can you try and reproduce this using a render test that will be ran in the CI? It might be something on your end, maybe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants