Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markeroptions type misleading #4115

Open
WuMianzhi opened this issue May 16, 2024 · 1 comment
Open

Markeroptions type misleading #4115

WuMianzhi opened this issue May 16, 2024 · 1 comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed

Comments

@WuMianzhi
Copy link

WuMianzhi commented May 16, 2024

The type of opacity in MarkerOption should be number, why the type is defined as string in typescript, also opacityWhenCovered

@HarelM
Copy link
Member

HarelM commented May 16, 2024

It's a string since this value is passed straight to the css which uses strings.
Feel free to open a PR to change that.

@HarelM HarelM added enhancement New feature or request PR is more than welcomed Extra attention is needed labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants