Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the recalculateZoom to the end of the movement. #4132

Merged
merged 3 commits into from
May 18, 2024
Merged

Move the recalculateZoom to the end of the movement. #4132

merged 3 commits into from
May 18, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented May 17, 2024

Launch Checklist

Fixes #4125 - by moving the recalculate zoom from the moveend event handler to the end of the movement.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (5ab0099) to head (8e9eae7).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
+ Coverage   86.45%   86.59%   +0.13%     
==========================================
  Files         242      242              
  Lines       33041    33042       +1     
  Branches     2020     2220     +200     
==========================================
+ Hits        28566    28612      +46     
+ Misses       3496     3457      -39     
+ Partials      979      973       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member Author

HarelM commented May 17, 2024

@olsen232 would be great to have your input here.

@olsen232
Copy link
Contributor

I'm on holiday until June 8... just had a tiny look at this, didn't immediately understand it. I don't really have any wisdom about how this code should look, I've just been identifying and fixing bugs case by case

src/ui/handler_manager.ts Show resolved Hide resolved
@HarelM
Copy link
Member Author

HarelM commented May 18, 2024

@olsen232 thanks for looking into it.
I'll merge this and hopefully most of the zoom related stuff will be solved after this.
If you happen to find other bugs feel free to tackle them.
Cc: @prozessor13

@HarelM HarelM merged commit c434f92 into main May 18, 2024
15 checks passed
@HarelM HarelM deleted the 4125-fix branch May 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash is not synced with map position when terrain is enabled.
4 participants