Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support git dependencies #253

Open
tarot opened this issue Dec 4, 2017 · 1 comment
Open

Please support git dependencies #253

tarot opened this issue Dec 4, 2017 · 1 comment

Comments

@tarot
Copy link

tarot commented Dec 4, 2017

Git dependencies (like following) doesn't work due to missing prepack or prepare scripts.

"dependencies": {
    "react-lightning-design-system": "github:mashmatrix/react-lightning-design-system"
}

I think it is better to use prepare instead of prepublish.

@stomita
Copy link
Collaborator

stomita commented Dec 8, 2017

@tarot
I think the "prepare" script will not run when it is installed via npm install in other package. It should be "preinstall" to run correctly in the package install of depending project. Anyway the build will fail as it doesn't include devDependencies.

I'm against for building (=transpiling) scripts on demand because it forces to download many modules which is only required in building phase and not needed in runtime.

To refer the master or arbitrary branch on Github other than the published, we should consider including the built files in Git commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants