Favicon is considered orphaned media

[cadusilva]

Steps to reproduce the problem

1. Upload a favicon in Branding settings
2. Run tootctl media remove-orphans
3. Favicon .png is now gone, but .ico remains.
   ...

Expected behaviour

Favicon not to be considered orphaned media

Actual behaviour

Favicon is considered orphaned media and deleted

Detailed description

After #30040, admins can now upload favicons to their instances. But the tootctl media remove-orphans command considers them as orphaned media, so the .png files are deleted. The .ico version is preserved, but the favicon used by browsers is the .png one, so they fail to show a favicon at all. Akkoma instances also fails to present the favicon.

I, [2024-05-13T10:04:45.895906 #421984]  INFO -- : [dotenv] Loaded .env.production
(...)
Found and removed orphan: site_uploads/files/000/000/019/16/724461bd9f815f15.png                                 
Found and removed orphan: site_uploads/files/000/000/019/32/724461bd9f815f15.png                                 
Found and removed orphan: site_uploads/files/000/000/019/48/724461bd9f815f15.png
(...)

Mastodon instance

bolha.one

Mastodon version

v4.3.0-alpha.3-1959365

Technical details

If this is happening on your own Mastodon server, please fill out those:

• Ruby version: 3.3.1 (2024-04-23 revision c56cd86388)
• Node.js version: v20.13.0