-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A lot of SDK CIs fail #4641
Comments
meili-bors bot
added a commit
that referenced
this issue
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=Kerollmops a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this issue
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this issue
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=irevoire a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this issue
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this issue
May 21, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Last week on May, 13th, all is green: https://github.com/meilisearch/meilisearch/actions/runs/9057979415
Today, our scheduled job reveals multiple CI failing: https://github.com/meilisearch/meilisearch/actions/runs/9154249771
I don't know what has been merged, but I think there is a significant impact.
The text was updated successfully, but these errors were encountered: