Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of SDK CIs fail #4641

Closed
curquiza opened this issue May 20, 2024 · 0 comments · Fixed by #4644
Closed

A lot of SDK CIs fail #4641

curquiza opened this issue May 20, 2024 · 0 comments · Fixed by #4644
Labels
bug Something isn't working as expected
Milestone

Comments

@curquiza
Copy link
Member

Last week on May, 13th, all is green: https://github.com/meilisearch/meilisearch/actions/runs/9057979415

Today, our scheduled job reveals multiple CI failing: https://github.com/meilisearch/meilisearch/actions/runs/9154249771

I don't know what has been merged, but I think there is a significant impact.

@curquiza curquiza added the bug Something isn't working as expected label May 20, 2024
@curquiza curquiza added this to the v1.9.0 milestone May 20, 2024
meili-bors bot added a commit that referenced this issue May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=Kerollmops a=irevoire

Reverts #4544

Fixes #4641

I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking.

There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now.

Co-authored-by: Tamo <irevoire@protonmail.ch>
Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot added a commit that referenced this issue May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire

Reverts #4544

Fixes #4641

I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking.

There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now.

Co-authored-by: Tamo <irevoire@protonmail.ch>
Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot added a commit that referenced this issue May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=irevoire a=irevoire

Reverts #4544

Fixes #4641

I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking.

There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now.

Co-authored-by: Tamo <irevoire@protonmail.ch>
Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot added a commit that referenced this issue May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire

Reverts #4544

Fixes #4641

I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking.

There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now.

Co-authored-by: Tamo <irevoire@protonmail.ch>
Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot added a commit that referenced this issue May 21, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire

Reverts #4544

Fixes #4641

I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking.

There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now.

Co-authored-by: Tamo <irevoire@protonmail.ch>
Co-authored-by: Tamo <tamo@meilisearch.com>
@meili-bors meili-bors bot closed this as completed in abe2977 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant