Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full absolute path #16

Open
AlexNodex opened this issue Oct 7, 2016 · 14 comments
Open

Full absolute path #16

AlexNodex opened this issue Oct 7, 2016 · 14 comments
Labels

Comments

@AlexNodex
Copy link

Why does the module prepend it's own path to the passed path in readdirSync?

Surely this is an oversight?

@jonathanbarton
Copy link

jonathanbarton commented Oct 13, 2016

I didn't see this documented tbh, but if you look in the code there is an option cwd that can be added to your options {}. i.e. var files = glob.readdirSync(my_path, {cwd: __dirname});
This fixed me up and I believe this mirrors typical glob functionality I've seen elsewhere.

Sidenote: @jonschlinkert your code is really pretty :)

@doowb
Copy link
Member

doowb commented Oct 14, 2016

@AlexNodex do you have an example to reproduce the error you're seeing?
I'm not able to reproduce it so you might be using a different pattern than me.

If you don't pass in the cwd on the options, then '.' will be used which resolves to the current working directory for me.

@AlexNodex
Copy link
Author

It doesn't matter what I pass in, it prefixes the directory with the working directory even if I put the full absolute path in.

@doowb
Copy link
Member

doowb commented Oct 14, 2016

it prefixes the directory with the working directory

That's different than:

the module prepend it's own path

I think I see the issue, but it would be helpful to have a code example showing what's happening and possibly a failing unit test showing what's expected.

@jonathanbarton
Copy link

I noticed the glob.sync() feature which parities readdirSync in the glob package does not behave this way, just fyi

@AlexNodex
Copy link
Author

This is why it's confusing, no other module works by prefixing anything!

@quinton-ashley
Copy link

Why hasn't this been fixed?

@jonschlinkert
Copy link
Member

@quinton-ashley please clarify your question. Are you asking what the technical hurdles are?

@jonschlinkert
Copy link
Member

@quinton-ashley why haven't you answered?

@jonschlinkert
Copy link
Member

@quinton-ashley I'm waiting for a response. Why haven't you answered my question?

@jonschlinkert
Copy link
Member

@quinton-ashley please explain why you asked your question.

@quinton-ashley
Copy link

Did I stutter? You marked this as a bug months ago why hasn't it been a priority? Seems like a pretty bad flaw for a project called glob-fs to not be able to access the rest of the filesystem.

@jonschlinkert
Copy link
Member

Unless you paid for this to be fixed, and you are quite literally owed an explanation, there is never going to be a time when asking this question is acceptable. Even if you had contributed something of value to this project (or any other project) that makes you feel like you have a right to ask such a question, which you haven't, you would still not be entitled to an answer. And if you had paid and asked in such a tone, I wouldn't take you as a client again.

I don't care how much you are frustrated by a bug. If you can't grasp the simple fact that free and open source software is, in fact, free and open source and that I do this on my own spare time and do not owe you anything at all - including an explantation as to how I spend my time, then I don't want you using my software at all. You, and people like you, are a detriment to the field, I have wasted my time responding to you - at the cost of being productive, and I somehow feel diminished knowing that you and I both work in the same industry. Please do not comment on any of my projects again.

@jonschlinkert
Copy link
Member

You might stutter, but I'll never know about it because I don't want to hear another word from you. You've been blocked.

@micromatch micromatch locked and limited conversation to collaborators May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants