Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support and other languages ? #346

Open
PrestigeDevop opened this issue Apr 29, 2024 · 4 comments
Open

RTL support and other languages ? #346

PrestigeDevop opened this issue Apr 29, 2024 · 4 comments
Assignees

Comments

@PrestigeDevop
Copy link

Hello , it seems that the model library doesn't support the Arabic language .. not sure if this due to the model-qa script or because the inference - runtime doesn't support it ?

it does actually output Arabic prediction but it doesn't respond if there's question mark "؟" at the end for a Q&A test.

image

@natke natke self-assigned this Apr 29, 2024
@natke
Copy link
Contributor

natke commented Apr 29, 2024

Thank you @PrestigeDevop! We will look into this for you

@natke
Copy link
Contributor

natke commented May 3, 2024

Hi @PrestigeDevop

We have a streaming detokenization issue for which a fix is currently in progress.

Can you please try running your input with the model-generate.py script also in the examples/python folder? This will output the generated text in one operation rather than streaming one token at a time.

python model-generate..py -m <path to your model> -pr <your prompt>

@natke
Copy link
Contributor

natke commented May 21, 2024

Hi again @PrestigeDevop,

We have made a number of fixes in the decoding functionality. Can you please try again with the latest release onnxruntime-genai 0.2.0?

@PrestigeDevop
Copy link
Author

Hi again @PrestigeDevop,

We have made a number of fixes in the decoding functionality. Can you please try again with the latest release onnxruntime-genai 0.2.0?

HI there, thanks for your support ..

running phi3-qa.py seems work just fine (using the same model too) so it seems the issue with model-qa.py (still occur )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants