Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: Please add executing methods using yarn instead of npx #30012

Closed
2gn opened this issue Mar 20, 2024 · 3 comments · Fixed by #30884
Closed

[Docs]: Please add executing methods using yarn instead of npx #30012

2gn opened this issue Mar 20, 2024 · 3 comments · Fixed by #30884
Labels
open-to-a-pull-request The feature request looks good, we are open to reviewing a PR P3-collecting-feedback

Comments

@2gn
Copy link

2gn commented Mar 20, 2024

Page(s)

Running the example test

Running the example test in UI mode

Description

These pages introduces commands that use npx, but for yarn users, it is not appropriate and executing those commands in vain may put them into unknown errors.

For example, npx playwright test should be yarn run playwright test .
@moghadam53
Copy link

I

@yury-s
Copy link
Member

yury-s commented Mar 20, 2024

Feel free to send a PR to add other package manager examples similar to https://playwright.dev/docs/intro#installing-playwright

@yury-s yury-s added open-to-a-pull-request The feature request looks good, we are open to reviewing a PR P3-collecting-feedback labels Mar 20, 2024
atmnk added a commit to atmnk/playwright that referenced this issue May 17, 2024
@atmnk
docs: adds all three package manager commands on js introduction page
c2097a2 
adds all three package manager commands on introduction page namley npm yarn and pnpm at all places earlier only npx and npm command were present
Fixes microsoft#30012
@atmnk atmnk mentioned this issue May 17, 2024
Merged
@atmnk
Copy link
Contributor

atmnk commented May 17, 2024

@yury-s I haven't scanned documentation to check this discrepancy on every other page. Only fixed the mentioned pages on this issue with above PR.

atmnk added a commit to atmnk/playwright that referenced this issue May 17, 2024
@atmnk
docs: aligns packagem manager installation commands with create playw…
dd06cbe 
…right

aligns package manager installation commands with create playwright
Fixes microsoft#30012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
open-to-a-pull-request The feature request looks good, we are open to reviewing a PR P3-collecting-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: adds all three package manager commands on js introduction page atmnk/playwright
4 participants
@yury-s @atmnk @2gn @moghadam53