New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fetch required column properties when starting edit data session #1697

Open

Charles-Gagnon opened this issue Sep 16, 2022 · 0 comments

Contributor

Charles-Gagnon commented Sep 16, 2022

From #1691 (comment)

I highly recommend using smoREsult.Columns.ClearAndInitialize, passing a filter to exclude the undesirable rows on the server side and also passing the names of the properties you reference.
Otherwise perf is going to be really bad for objects with many columns.

Referring to

sqltoolsservice/src/Microsoft.SqlTools.ServiceLayer/EditData/SmoEditMetadataFactory.cs

Line 98 in 21470b0

for (int i = 0; i < smoResult.Columns.Count; i++)

Charles-Gagnon mentioned this issue

Remove dropped ledger columns from Edit Data columns #1691

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment