Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make error/warning signal delay configurable #211363

Closed
meganrogge opened this issue Apr 25, 2024 · 6 comments · Fixed by #212834
Closed

make error/warning signal delay configurable #211363

meganrogge opened this issue Apr 25, 2024 · 6 comments · Fixed by #212834
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-signal Issues pertaining to accessibility signals feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@meganrogge
Copy link
Contributor

          A 1-second delay, in my opinion, does not significantly improve user experience. Ideally, this delay should be configurable, with a default setting of at least 3 seconds. setting `editor.hover.delay` is a viable workaround; however, it falls short in addressing the issue when an error or warning state has already been triggered.

Originally posted by @rperez030 in #204257 (comment)

@meganrogge meganrogge self-assigned this Apr 25, 2024
@meganrogge meganrogge added feature-request Request for new features or functionality accessibility-signal Issues pertaining to accessibility signals labels Apr 25, 2024
@meganrogge meganrogge added this to the May 2024 milestone Apr 25, 2024
@meganrogge
Copy link
Contributor Author

meganrogge commented Apr 25, 2024

private _getDelay(signal: AccessibilitySignal, modality: AccessibilityModality): number {

@kieferrm kieferrm added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label May 4, 2024
@meganrogge
Copy link
Contributor Author

meganrogge commented May 14, 2024

@jooyoungseo, @rperez030 do you have suggestions for the default delays when:

  1. navigating between lines, error (currently 400ms for sound, 3000ms for announcement)
  2. navigating between lines, warning (currently 400ms for sound, 3000ms for announcement)
  3. navigating between positions, error (currently 100ms for sound, 1000ms for announcement)
  4. navigating between positions, warning (currently 100ms for sound, 1000ms for announcement)

@hediet As settings, this could be represented like:

accessibility.signalOptions.errorDelays: {
    soundAtPosition:
    announcementAtPosition:
    soundAtLine:
    announcementAtLine:
}
accessibility.signalOptions.warningDelays: {
    soundAtPosition:
    announcementAtPosition:
    soundAtLine:
    announcementAtLine:
}

There are many other ways this could be represented though. WDYT?

@hediet
Copy link
Member

hediet commented May 15, 2024

There are many other ways this could be represented though. WDYT?

I like it! We should keep it open for future refactorings though. Thanks for implementing this!

Please implement this in the service and make every audio cue have these delay fields in the interface (though they might all come from the same setting).

@rperez030
Copy link
Contributor

  1. navigating between lines, error (currently 400ms for sound, 3000ms for announcement)

Good

  1. navigating between lines, warning (currently 400ms for sound, 3000ms for announcement)

Good

  1. navigating between positions, error (currently 100ms for sound, 1000ms for announcement)

1000ms for sound, 3000ms for announcement

  1. navigating between positions, warning (currently 100ms for sound, 1000ms for announcement)

1000ms for sound, 3000ms for announcement

@meganrogge What about typing? Would that be equivalent to navigating between positions? It would be great to get additional feedback about these defaults.

@meganrogge
Copy link
Contributor Author

@meganrogge What about typing? Would that be equivalent to navigating between positions?

Yes, exactly.

Agree re more feedback. If I merge this soon, then we can get feedback before it's released to stable.

@meganrogge
Copy link
Contributor Author

meganrogge commented May 15, 2024

@rperez030 I had misunderstood, here is the current status:

  1. navigating between positions, error or warning (currently 100ms for sound, 1000ms for announcement)
  2. navigating between lines, any signal (currently 400ms for sound, 3000ms for announcement)

So we should probably have

accessibility.signalOptions.delays: {
   general: {
    sound:, 
    announcement:,
   },
    warningAtPosition: {
    sound:
    announcement:
    },
   errorAtPosition: {
   sound:
   announcement:
    },
}

meganrogge added a commit that referenced this issue May 15, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 22, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 24, 2024
@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-signal Issues pertaining to accessibility signals feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants