Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Fix: makeblockteam.mBlock, fix hash #153031

Closed
wants to merge 3 commits into from
Closed

Package Fix: makeblockteam.mBlock, fix hash #153031

wants to merge 3 commits into from

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented May 10, 2024 •
edited by microsoft-github-policy-service bot

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Resolves: #153008

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 10, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label May 10, 2024
@vikingnope
Copy link
Contributor Author

I think the exe might be a dynamic hash, so I decided to change the installer to an msi

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 10, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@vikingnope
Copy link
Contributor Author

I have no idea what is wrong with this file:

image

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Validation-Shell-Execute Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 10, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 10, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

2024-05-10 06:16:57.628 [CORE] DeliveryOptimization error: 0x80072f76, extended error: 0x00000000
2024-05-10 06:16:57.683 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(289)\WindowsPackageManager.dll!00007FFACE52A465: (caller: 00007FFACE52AD01) Exception(1) tid(1e9c) 80072F76

(Automated response - build 880.)

@stephengillie
Copy link
Collaborator

Manual Validation ended with:

2024-05-10 08:42:52.448 [CORE] DeliveryOptimization error: 0x80072f76, extended error: 0x00000000
2024-05-10 08:42:52.449 [FAIL] C:__w\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(289)\WindowsPackageManager.dll!00007FFE45B4F180: (caller: 00007FFE45B4FACC) Exception(1) tid(a60) 80072F76
2024-05-10 08:42:54.355 [CLI ] Package hash verification failed. SHA256 in manifest [9d5bf8cddc60080fd570bb79bfc5867daf56a40f45ee9a2dace714ebc555c5c5] does not match download [a83bba255d2d6e424f058c38a204f273a4f40bcac38c8283f551a7056b605640]

(Automated response - build 880.)

@vikingnope
Copy link
Contributor Author

I think the SHA256 is dynamic, it keeps changing

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 10, 2024
@stephengillie
Copy link
Collaborator

  • If the SHA256 keeps changing to a new value, then it might be receiving continuous updates, possibly at the end of a CI/CD pipeline.
  • If the SHA256 keeps changing and reverting, then it might be getting an error page sometimes.

Either way complicates installing through a package manager.

@vikingnope
Copy link
Contributor Author

vikingnope commented May 10, 2024 •
edited

Don't know what can be done about this anymore, because as you said it does complicate this a lot.

@vikingnope vikingnope closed this May 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label May 13, 2024
@vikingnope vikingnope removed their assignment May 15, 2024
@vikingnope vikingnope deleted the fix-hash-mblock branch May 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stephengillie stephengillie

Labels
Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Issue]: makeblockteam.mBlock
3 participants
@vikingnope @wingetbot @stephengillie