feat(bent): add http request timeout option for nodejs #132

mcgradycchen · 2020-12-07T08:53:32Z

I want to add a timeout option for nodejs http request.

The usage will be

const req = bent('GET', 200, 201);
req.timeout = 1000 * 10;
(async () => {
    await req('http://192.123.21.12/hello', null, null);
})();

@mikeal Please ignore the whitespace changes for this PR

Under the strict mode, we cannot use the assigned currying arrow function chain

'use strict'
const b = () => req = () => {
  return new Promise((resolve, reject) => {
    console.log(req.data)
    resolve(1)
  })
}

Then, have to change to the following explicitly way, tha't why so many whitespace changes

'use strict'
const b = () => {
  const req = () => {
    return new Promise((resolve, reject) => {
      console.log(req.data)
      resolve(1)
    })
  }
  return req
}

Thanks,
McGrady

mcgradycchen added 3 commits December 7, 2020 16:48

feat(bent): add http request timeout option for nodejs

3a2e076

fix(bent): standardjs lint check error

e798d58

fix(bent): test coverage less than 100%

9a40b26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bent): add http request timeout option for nodejs #132

feat(bent): add http request timeout option for nodejs #132

mcgradycchen commented Dec 7, 2020 •

edited

feat(bent): add http request timeout option for nodejs #132

Are you sure you want to change the base?

feat(bent): add http request timeout option for nodejs #132

Conversation

mcgradycchen commented Dec 7, 2020 • edited

mcgradycchen commented Dec 7, 2020 •

edited