Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve maximum mention count limit #13785

Open
1 task done
Hoto-Cocoa opened this issue May 2, 2024 · 0 comments
Open
1 task done

Improve maximum mention count limit #13785

Hoto-Cocoa opened this issue May 2, 2024 · 0 comments
Labels
鈿狅笍bug? This might be a bug

Comments

@Hoto-Cocoa
Copy link
Contributor

馃挕 Summary

Currently, Misskey has mention count limits for every note, by default of 20 mentions.

So, If I mention 18 users in A instance and 3 users in B instance in one note, this note has 21 mentions, so this note will not be accepted.

Also, If I mention users more than limits on that note, that note will just not be accepted and federated, even if all the mentioned users are mutually following the note author.

This note has 22 mentions but is not spam; all mentioned users are in a mutual following state with the note author, and I'm not mentioning more than 20 users in one instance.

hoto.moe (local, 7)
k.lapy.link (remote, 4)
nekoplanet.xyz (remote, 3)
social.silicon.moe (remote, 2)
stella.place (remote, 1)
daepi.so (remote, 1)
prism.place (remote, 1)
gameguard.moe (remote, 1)
cremebrul.ee (remote, 1)
munochi.moe (remote, 1)

Now I wish:

  • Not include mention in count If that user is a remote user
  • Not include mention in count If that user is mutually following state with note author

So I was planning to just implement this myself and open PR, but I don't know why this was implemented like this, so now I'm open this issue. If this is not an intended action, I will implement it myself and open a PR. Please let me know.

Thanks.

馃グ Expected Behavior

  • Not include mention in count If that user is a remote user
  • Not include mention in count If that user is mutually following state with note author

馃が Actual Behavior

  • Include mention in count If that user is a remote user
  • Include mention in count If that user is mutually following state with note author

馃摑 Steps to Reproduce

No response

馃捇 Frontend Environment

No response

馃洶 Backend Environment (for server admin)

* Installation Method or Hosting Service: Docker compose
* Misskey: 2024.3.1
* Node: 20.10.0
* PostgreSQL: 15
* Redis: 7
* OS and Architecture: Ubuntu 20.04.4 LTS

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@Hoto-Cocoa Hoto-Cocoa added the 鈿狅笍bug? This might be a bug label May 2, 2024
@Hoto-Cocoa Hoto-Cocoa changed the title Maximum mention count includes remote users Improve maximum mention count limit May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
鈿狅笍bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

1 participant