Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve midi port detection across platforms #199

Open
mmckegg opened this issue Aug 21, 2016 · 1 comment
Open

improve midi port detection across platforms #199

mmckegg opened this issue Aug 21, 2016 · 1 comment
Labels

Comments

@mmckegg
Copy link
Owner

mmckegg commented Aug 21, 2016

As reported by @voseone here, other platforms may prefix or suffix the name with something extra. This throws off portMatch which expects that the name start with the given sequence.

It might just be a matter of relaxing the matchers to not require the port name "starts with", rather will match any part of the name. This is probably okay, as false positives aren't really a problem as this is more just to help the user and cut down on noise.

@mmckegg mmckegg added the bug label Aug 21, 2016
@mmckegg
Copy link
Owner Author

mmckegg commented May 12, 2017

Also reported on this YouTube comment

But when I test it in my machine, I can't reproduce. Maybe it only happens after switching USB ports or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant