Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in Safari's private mode #14

Open
martinheidegger opened this issue Jul 21, 2016 · 2 comments
Open

Broken in Safari's private mode #14

martinheidegger opened this issue Jul 21, 2016 · 2 comments
Labels

Comments

@martinheidegger
Copy link

We found that the Workshopper is broken on Safari 9.1.1 in the private mode.
JavaScript exits with a QuotaExceededError when accessing the localstorage: here

cc: @kei-nstn

@mmckegg mmckegg added the bug label Jul 22, 2016
@mmckegg
Copy link
Owner

mmckegg commented Jul 22, 2016

Interesting, thanks for reporting. Looks like Safari disables localStorage when running in private mode.

I guess the fix is to put some kind of try/catch on storage, and only persist if available.

@JakeChampion
Copy link

You can use Superstore to work around the localStorage quirks/bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants