Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-align: inherit on columns #537

Open
emcarru opened this issue Jan 5, 2018 · 1 comment
Open

text-align: inherit on columns #537

emcarru opened this issue Jan 5, 2018 · 1 comment

Comments

@emcarru
Copy link

emcarru commented Jan 5, 2018

Today I came across the issue that column unset my text-align, because it adds text-align: inherit. As I am working mobile first, to solve this I would need to re-set my text-align across each breakpoint. This is not a big issue, but it was an unexpected quirk.

An example of the issue:

.example
    column(1/2)
    text-align: right

    @media (min-width: 576px)
        column(1/3) // outputs `text-align: inherit` which over-rides the text-align above

I found an older issue relating to this here, where it seems like it the solution was removing text-align: inherit from column.

Is there a reason for setting text-align: inherit that I am missing, or can this be removed? (Perhaps due to stack having an align option that sets text-align?)

@corysimmons
Copy link
Contributor

Yeah stack should remove text-align and text-align should be removed from column as well, with a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants