Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor MongoQuery.add_filters() #13

Closed
timgraham opened this issue May 6, 2024 · 0 comments · Fixed by #33
Closed

refactor MongoQuery.add_filters() #13

timgraham opened this issue May 6, 2024 · 0 comments · Fixed by #33
Assignees
@WaVEV

Comments

@timgraham
Copy link
Collaborator

Jib: We should cut a task to break up and simplify this function. It's far too lengthy and confusing, especially as we get into the negation logic. It isn't encapsulated well, so it gets hard to remember what was happening previously.
@timgraham timgraham mentioned this issue May 6, 2024
Merged
@WaVEV WaVEV self-assigned this May 17, 2024
@timgraham timgraham mentioned this issue May 22, 2024
Merged
timgraham added a commit to WaVEV/django-mongodb that referenced this issue May 24, 2024
@WaVEV @timgraham
refactor query generation
854317a 
fixes mongodb-labs#13, mongodb-labs#22

Co-authored-by: Tim Graham <timograham@gmail.com>
timgraham added a commit to WaVEV/django-mongodb that referenced this issue May 24, 2024
@WaVEV @timgraham
refactor query generation
7c833f4 
fixes mongodb-labs#13, mongodb-labs#22

Co-authored-by: Tim Graham <timograham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WaVEV WaVEV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor query generation WaVEV/django-mongodb
2 participants
@timgraham @WaVEV