add query debug support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, this part may not be necessary because we will have standardized logging in our MongoClient. It captures the call operation details. I'll say leave it for now, though. |
Jibola
approved these changes
May 20, 2024
|
Thanks, I'll keep that in mind, however, I think trying to make use of that logging (capturing it, filtering it, reformatting it) would probably be more complicated than this implementation. |
timgraham
commented
May 21, 2024
| func = getattr(self.collection, method) | ||
| # Collection.insert_one() mutates args[0] (the document) by adding | ||
| # the _id. deepcopy() to avoid logging that version. | ||
| original_args = copy.deepcopy(args) |
There was a problem hiding this comment.
Maybe this deepcopy should be omitted. I just came across this in the MongoDB docs: "Copying the document to insert before adding the _id field would be prohibitively expensive for most high write volume applications."
It was surprising to me to see queries logged as if the user has supplied an _id, but perhaps it's okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24