Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Factor #5

Open
antonis-papaioannou opened this issue Dec 22, 2019 · 0 comments
Open

Scale Factor #5

antonis-papaioannou opened this issue Dec 22, 2019 · 0 comments

Comments

@antonis-papaioannou
Copy link

I expected to use the scaleFactor parameter to increase the size of db.
Instead, looking into the source code (util/scaleparameters.py), I surprisingly found out that the scaleFactor parameter is used to reduce the size of the database:

items = int(constants.NUM_ITEMS/scaleFactor)
districts = int(max(constants.DISTRICTS_PER_WAREHOUSE, 1))
customers = int(max(constants.CUSTOMERS_PER_DISTRICT/scaleFactor, 1))
newOrders = int(max(constants.INITIAL_NEW_ORDERS_PER_DISTRICT/scaleFactor, 0))

Is this correct or should we multiply the default values with the scaleFactor parameter?

(Perhaps we should also replace the assertion in init of ScaleParameters class: assert 1 <= items and items <= constants.NUM_ITEMS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant