Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing with timeout disabled gives an ArgumentError Exception #48

Open
chasemcdo opened this issue Aug 19, 2022 · 1 comment
Open
Labels

Comments

@chasemcdo
Copy link

Following the documentation I am able to build an index using Artwork.update_ngram_index; however, some of the datasets I wish to query require the disablement of timeout.

Artwork.update_ngram_index(timeout: false)

Returns the following error:

(byebug) Artwork.update_ngram_index(timeout: false)
*** ArgumentError Exception: wrong number of arguments (given 1, expected 0)

I notice two declarations of update_ngram_index which could be where my issues stem from.
The first doesn't appear to have been updated to take in arguments and is what my code seems to be invoking.

The second was updated to allow arguments, but doesn't seem to get invoked by my code.

I believe to have worked around this issue by directly calling Artwork.each(&:update_ngram_index) though this could be an issue with my own setup if others are not experiencing this.

@dblock
Copy link
Contributor

dblock commented Aug 20, 2022

Looks like we missed it. Care to PR?

This library needs a bit of work, hasn't been updated for a while. Maybe move from Travis-CI to GHA, and add support for mongoid8 first? See the last PRs on https://github.com/mongoid/mongoid-compatibility for some changes to copy-paste.

@dblock dblock added the bug? label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants