Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo-ng - update to latest nativescript and angular #257

Open
two-bridges opened this issue Dec 4, 2022 · 2 comments
Open

demo-ng - update to latest nativescript and angular #257

two-bridges opened this issue Dec 4, 2022 · 2 comments

Comments

@two-bridges
Copy link
Contributor

two-bridges commented Dec 4, 2022

Hi team,

I noticed that the demo-ng needs updating (package.json is showing old versions)

nativescript-core is v5 (v8.x is the latest)
https://github.com/nativescript-community/ble/blob/master/demo-ng/package.json#L33

angular v7 (should be v14 or v15 is the latest)
https://github.com/nativescript-community/ble/blob/master/demo-ng/package.json#L22

{
  "dependencies": {
    "@angular/core": "~7.2.1",
    "@nativescript/core": "~5.1.2",
  }
}

I can submit an updated demo-ng to this repository

I have updated demo-ng on my local machine. Just wondering if I can get permissions to create a PR in this repo? Or should I just fork the repo and then provide a link to upgraded code that way?

Cheers

@two-bridges
Copy link
Contributor Author

I've worked out how to open a PR from a fork now... 🎉

I'll create a PR for this soon. Today or next week sometime... It's not urgent

@two-bridges
Copy link
Contributor Author

Here's the PR:

#259

Cheers 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant