Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing export of MPPointF #56

Open
vthil3049 opened this issue Sep 29, 2023 · 5 comments
Open

Missing export of MPPointF #56

vthil3049 opened this issue Sep 29, 2023 · 5 comments

Comments

@vthil3049
Copy link

Summary
I'm trying to implement a custom class which implements the IMarker interface.
You have the following definition of the interface in IMarker.d.ts

import { Highlight } from '../highlight/Highlight';

import { Entry } from '../data/Entry';

import { MPPointF } from '../utils/MPPointF';
import { Canvas } from '@nativescript-community/ui-canvas';
export interface IMarker {
    getOffset(): MPPointF;
    getOffsetForDrawingAtPoint(posX: any, posY: any): MPPointF;
    refreshContent(e: Entry, highlight: Highlight): any;
    draw(canvas: Canvas, posX: any, posY: any): any;
}

But it seems like you forgot to export MPPointF for us developers to use. So, I'm unable to import it and implement the 2 methods that are supposed to return the offsets.

Expected Behavior
I expected it to be able to somehow import this in my application. I started with this import statement
import { MPPointF } from '@nativescript-community/ui-chart/utils;
and I've searched in all the folders in your package and I don't see an export for it anywhere

Possible Solution
Please export this and let us know where.

Device (please complete the following information):

  • Device: Pixel 3
  • Android Version Android 13 API v33
  • Library Version : 8.5.0

ADD A REWARD using Speed to SOLVE this issue QUICKLY and SUPPORT this project.

@farfromrefug
Copy link
Member

@vthil3049 you can simply import it like this import { MPPointF } from '@nativescript-community/ui-chart/utils/MPPointF;
everything is accessible in the plugin. No class is hidden

@vthil3049
Copy link
Author

Sorry its not working. We've also searched recursively inside your installation under node_modules/@nativescript-community/ui-chart/ and couldn't find it.

image

@vthil3049
Copy link
Author

Also, it would be really, really helpful to us if you can provide an example of creating and using a marker in angular in your demo site. Let me know if I have to open a separate issue for this request.
Thanks

@farfromrefug
Copy link
Member

@vthil3049 I see why. I'll fix it tomorrow. Sorry

@farfromrefug
Copy link
Member

@vthil3049 should be fixed in latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants