-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BottomSheet] No content shown when used with RAD SideDrawer #462
Comments
@alexander-mai sorry to hear that. If i find time i ll take a look, but i dont support RAD sidedrawer (too complex, too old, and not open source). I would advise to use |
Thank you @farfromrefug for your fast response. |
@alexander-mai not sure why it would not be possible. Do you have a link to an error ? |
I have tested it some years ago and there is also an Issue about the root problem: nativescript-community/ui-drawer#3. |
This issue was caused by 9a524e0 The problem appears to be the change in which view controller it's using to display the bottom sheet. In theory, it should be using the same one, provided it's not a nested bottom sheet. But instead currentView defaults to the root view, and the parentController becomes the view controller of that. But before, parentController was the nearest viewController up the view hierarchy. @farfromrefug, is this not the case? Edit: I can fix this issue for my app if I just comment out the |
@JWiseCoder thanks for investigating this! Indeed could be the issue. I ll take a look next week |
@farfromrefug - After some more testing, found it works on 7.2.11, but breaks on 7.2.12 (and thereafter). I think it was this commit where the parent was first being overridden: ae4d6cc |
In my opinion, the problem is caused by this change: cbd325c If I understand it right, setting |
@alexander-mai could be related yes. So you understand the reason why i now set RootView as parent is for the bottom sheet to correctly inherit root css variables/classes |
@alexander-mai @JWiseCoder should be fixed in latest! |
I have tested the changed from your pull request in my app with the current version of the bottomsheet and the RadSidedrawer as root element. It works perfectly. Thank you very much @farfromrefug. |
@alexander-mai can we close this now? |
Yes, I think so. |
An Empty white BottomSheet is shown, when it is used in Combination with RAD SideDrawer as Root-Element.
Which platform(s) does your issue occur on?
Please, provide the following version numbers that your issue occurs with:
Please, tell us how to recreate the issue in as much detail as possible.
Create an app with nativescript-ui-sidedrawer as root element. An opened bottomSheet is only white without any content.
On Android is the content of the bottomsheet correctly shown.
The problem exists since ui-material-bottomsheet version 7.2.43
Is there any code involved?
The text was updated successfully, but these errors were encountered: