Remove jQuery and Update Bootstrap #228
Comments
rockerBOO
changed the title
|
I wonder if it makes sense to use some lighter alternatives to Boostrap like one of these:
|
could be nice, but adds risk if they aren't as well-maintained ("alive") as bootstrap. |
Merged
justinmk
added a commit
that referenced
this issue
May 23, 2024
Related issue: #228 Things done in this pull request: - Update Bootstrap from 5.0 beta to 5.3.3. - Remove old normalize.css. Bootstrap already includes its own [reboot](https://getbootstrap.com/docs/5.3/content/reboot/). - Remove jquery. It isn't a dependency of Bootstrap in v5. The bootstrap.bundle.js includes popper.js as a replacement. - Update nix-shell, because the ruby version was too old to build. - Update navbar to match previous styling. There's also some new CSS classes to target things better. - Update fonts. Serif fonts weren't being used at all, and Inter wasn't being loaded in some places. Also Lato isn't being used at all anymore, so I removed the old files. - Clean up some CSS. TODO: There's some scripts that need to get their references updated to the correct filenames: - core: https://github.com/neovim/neovim/blob/40ce8577977fcdce8ad76863c70eb522e4cefd4d/scripts/gen_help_html.lua#L829 - docs: https://github.com/neovim/doc/blob/6f805e0d6085bd29ef881dcfe907638c943aac75/templates/report-header.sh.html#L11
|
Fixed by #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With Bootstrap 5.0, jQuery is no longer required. The feature we used that required it was the dropdowns in the header nav bar. Currently running Bootstrap 5.0 beta so no breaking issues should come up.
We can now remove jQuery and include the Bootstrap 5 javascript bundle (including popper.js) and slim down things a little.
See
_layouts/default.htmlhttps://getbootstrap.com/docs/5.0/migration/
https://getbootstrap.com/docs/5.0/getting-started/javascript/#still-want-to-use-jquery-its-possible
https://getbootstrap.com/docs/5.0/getting-started/introduction/#bundle
The text was updated successfully, but these errors were encountered: