Inbuilt comment feature not working properly for JSX files

[Antony-AXS]

Problem

when i type 'gcc; this is how it gets commented in a JSX file

Steps to reproduce

Expected behavior

this is how it should be for JSX when commented.

Neovim version (nvim -v)

0.10

Vim (not Nvim) behaves the same?

no

Operating system/version

ubuntu 22.04

Terminal name/version

GNOME Terminal 3.44.0 using VTE 0.68.0 +BIDI +GNUTLS +ICU +SYSTEMD

$TERM environment variable

xterm-256color

Installation

appimage

[towry]

vi-mode on zed works well with gcc on tsx file.

[zeertzjq]

Oops, I was wrong. https://github.com/tree-sitter/tree-sitter-javascript does support .jsx files, but it seems that the comment string may change even though the filetype doesn't change. From numToStr/Comment.nvim#133 it seems that this is quite a complicated problem.

[ribru17]

@zeertzjq Would you be opposed to a PR that sets the {/* ... */} comment string when the cursor is in a (jsx_element) node (maybe only checked in (javascript|typescript)react files)? I have had that in my own config for quite some time and it works fine. Or would that be out of scope for the built-in comment module since the parser isn't bundled

[clason]

Yes, that would be out of scope. React files are such a mess, you need a dedicated plugin to make sense of it. We shouldn't add one-off hacks for individual languages.

[folke]

This is a work-around I use in LazyVim to use nvim-ts-context-commentstring together with native comments:

local get_option = vim.filetype.get_option
vim.filetype.get_option = function(filetype, option)
  return option == "commentstring"
    and require("ts_context_commentstring.internal").calculate_commentstring()
    or get_option(filetype, option)
end

An alternative would be to at least expose vim._comment.get_commentstring so that it can be easily overridden,
OR have an option that always uses vim.bo.commentstring for a given buffer instead of treesitter.

[folke]

Just created a tiny plugin to enhance the native comments with support for custom comment strings for certain treesitter node types.

It's an alternative to ts-context-commentstring.

https://github.com/folke/ts-comments.nvim