Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove babel #241

Open
justinmk opened this issue Sep 6, 2023 · 1 comment
Open

deps: remove babel #241

justinmk opened this issue Sep 6, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@justinmk
Copy link
Member

justinmk commented Sep 6, 2023

Problem

Babel adds complication to the build/dependencies. We aren't using it for anything important, looks like it is used to add decorators support.

Solution

  • Remove babel.
  • Remove support for decorators. (Bump major version of Nvim node-client)

Notes

$ npm ci
npm WARN deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained
. Please use @babel/plugin-transform-class-properties instead.
@justinmk justinmk added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@justinmk
Copy link
Member Author

justinmk commented Feb 3, 2024

@billyvg @rhysd can you help me understand the use of babel in this project? It looks like babel is only used here:

"build": "babel src --out-dir lib",

babel is targeting node 8:

['@babel/preset-env', { targets: { node: '8.15.1' } }],

so I had expected it to translate packages/neovim/ to node8-compatible syntax, but seems like that isn't happening.

So if we want the "neovim" package to be compatible with an old target such as es2015, we currently can't rely on babel to polyfill es2022 libraries/features--rather we must avoid using es2022 libraries in our typescript code.

Is this a correct understanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant